Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete on Program plugin #1850

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Fix autocomplete on Program plugin #1850

merged 3 commits into from
Jan 26, 2023

Conversation

z1nc0r3
Copy link
Member

@z1nc0r3 z1nc0r3 commented Jan 25, 2023

Fixed the issue mentioned in #1803 which autocompletes the name + program description when the Show Description is enabled in the Program plugin.

@z1nc0r3 z1nc0r3 self-assigned this Jan 25, 2023
@github-actions

This comment has been minimized.

@@ -83,6 +83,7 @@ private static MatchResult Match(string query, IReadOnlyCollection<string> candi
public Result Result(string query, IPublicAPI api)
{
string title;
string titleOnly;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this variable name doesn't provide any information. and is this variable needed? In either case the value is the same as resultName.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no need for an extra variable. I just noticed that. We can use resultName as AutoCompleteText.

@VictoriousRaptor
Copy link
Contributor

Just set AutoCompleteText = resultName (localizedname in win32).

@z1nc0r3 z1nc0r3 requested a review from taooceros January 26, 2023 04:22
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (8)

autocompletes
dlgtitle
IPublic
Pbgra
rescap
uap
uwp
yyy

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:z1nc0r3/Flow.Launcher.git repository
on the dev branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/4012278108/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@VictoriousRaptor VictoriousRaptor merged commit 7fc7045 into Flow-Launcher:dev Jan 26, 2023
@jjw24 jjw24 added the bug Something isn't working label Feb 6, 2023
@jjw24 jjw24 modified the milestones: 1.12.2, 1.13.0 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants