Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything Search: Match Path #1848

Merged

Conversation

TheBestPessimist
Copy link
Contributor

This option makes searching take into account the full path of a file at once, instead of "chunks of the path delimited by "/" (folder separator)".

For example:

I have a folder D:/all/wallpapers/artstation/pics and nested folders here

In Everything, if i enable Search -> Match Path (Ctrl+U) i can simply type wall arts and it shows me all the correct files. It matches the folder D:/all/wallpapers/artstation/ and everything underneath it.

With FL, before this feature, i have to type wall*/arts to have the same. Typing wall*arts does not work either.

Basically i have to:

  1. add * to instruct "match all characters after wall until folder separator
  2. add / (folder separator) because * character does not match it

With this feature, it is enough to type wall arts, just like you would type in Everything. Space character works as a .* regexp over the full path of a file.

Moreover, this gives you even more flexibility, because now you can type characters from the middle of the path as well, and they will match, for example all tati brings you the same result.

Screenshot of the feature in action:
image

Closes: #1805
Closes: #1800

@TheBestPessimist TheBestPessimist marked this pull request as ready for review January 25, 2023 13:47
@github-actions

This comment has been minimized.

@TheBestPessimist TheBestPessimist force-pushed the #1800_Everything_search_full_path branch from 100dffe to 2b6c92c Compare January 26, 2023 06:50
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@TheBestPessimist TheBestPessimist force-pushed the #1800_Everything_search_full_path branch from c7a1968 to 1b9a879 Compare January 26, 2023 07:00
@github-actions

This comment has been minimized.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (2)

artstation
tati

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:TheBestPessimist/Flow.Launcher.git repository
on the #1800_Everything_search_full_path branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/4013082021/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@taooceros taooceros merged commit c99790b into Flow-Launcher:dev Jan 28, 2023
@taooceros
Copy link
Member

Thank you! I also really like this feature!

@TheBestPessimist
Copy link
Contributor Author

@taooceros when can i get the new plugin versions? will they auto update, or do you need to publish a new FL version? (ie 1.12.2)

@taooceros
Copy link
Member

try the new prerelease

@Garulf
Copy link
Member

Garulf commented Jan 29, 2023

This is such a cool way to do it. Awesome!

@TheBestPessimist TheBestPessimist deleted the #1800_Everything_search_full_path branch January 30, 2023 10:28
@jjw24 jjw24 added the enhancement New feature or request label Feb 6, 2023
@jjw24 jjw24 added this to the 1.13.0 milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement - add Everything setting Match Path
4 participants