Fixed lagginess for notes with many icons #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes great, it works |
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small cache for font size that expires after 2 seconds. if many re-renders of inline icons happen at once (every icon in every internal link onscreen gets rerendered in the dom whenever you type), it won't spend a lot of time in this method any more.
I tried for a while to get at the root of the problem which is that it re-renders all the icons onscreen everytime you type anything, but wasn't able to get that to work well, so went with this simpler fix.
Fixes issue #602
See before/after examples:
BEFORE:
iconize_beforefix.mp4
AFTER:
iconize_afterfix.mp4