Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Lucide support #452

Closed
NomarCub opened this issue Apr 13, 2024 · 6 comments
Closed

Native Lucide support #452

NomarCub opened this issue Apr 13, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@NomarCub
Copy link

As I understand, Obsidian has Lucide natively: https://docs.obsidian.md/Reference/CSS+variables/Foundations/Icons.
I'd like to use Lucide icons without downloading them as a pack. This other plugin already does this: https://github.com/aidenlx/obsidian-icon-shortcodes.

@FlorianWoelki FlorianWoelki added the enhancement New feature or request label Apr 17, 2024
@FlorianWoelki FlorianWoelki self-assigned this Apr 17, 2024
@FlorianWoelki FlorianWoelki moved this to Todo in Iconize Board Apr 17, 2024
@FlorianWoelki FlorianWoelki moved this from Todo to In Progress in Iconize Board Jun 28, 2024
@FlorianWoelki
Copy link
Owner

Hey there, I've added native Lucide support without downloading any additional icon pack. Would it be possible to get some test users for this feature?

You can use the beta plugin by using BRAT.

@FlorianWoelki FlorianWoelki moved this from In Progress to Done in Iconize Board Jun 28, 2024
@NomarCub
Copy link
Author

How do I try it? I'm not that familiar with BRAT. Don't you have to make a GitHub release for it to work?

I added https://github.com/FlorianWoelki/obsidian-iconize with Add Beta plugin, but clicking on the Lucide set still downloads the zip.

@FlorianWoelki
Copy link
Owner

How do I try it? I'm not that familiar with BRAT. Don't you have to make a GitHub release for it to work?

I added https://github.com/FlorianWoelki/obsidian-iconize with Add Beta plugin, but clicking on the Lucide set still downloads the zip.

Yeah I think you are right. I am also not familiar with BRAT and thought that it works with just the GH link. For me it was working, but I'll investigate this tomorrow :D
Nevertheless, if you feel comfortable with it, you can always try to build the project and paste the files by yourself.

@NomarCub
Copy link
Author

I built it, and it works like a charm, thank you!

One thing I noticed while building: https://github.com/FlorianWoelki/obsidian-iconize/blob/main/copy-file.js#L11
I think you should use path.join and basename here, so that the code is agnostic to whether the path has a separator (/ or \) at the end. Like so: const destPath = path.join(target.dest, path.basename(target.src));. You can avoid error prone string based path manipulation this way.

@FlorianWoelki
Copy link
Owner

Awesome. Yeah you are right, thank you for the suggestion!

@FlorianWoelki
Copy link
Owner

It's now released in v2.14.0.

@FlorianWoelki FlorianWoelki moved this from Done to Deployed in Iconize Board Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants