Fix/gpx export chrome #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a trail export problem with Chrome-based browsers.
The export function used to add a duplicate "xmlns" attribute to the tag in Chrome and Edge, which led to a malformed GPX file (see #128). Additionally, GeoJSONs were produced as empty lists, like
{"type":"FeatureCollection","features":[]}.I fixed the malformed XML issue by declaring the default namespace and adding it back in for Firefox (which seems to swallow it), instead of the other way around. By doing that, the second problem resolved itself as well and GeoJSONs are now produced as expected.
Tested in Edge and Firefox. All outputs tested to be valid JSON and XML files.