Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added masonary layout #175

Closed
wants to merge 6 commits into from
Closed

added masonary layout #175

wants to merge 6 commits into from

Conversation

hovox
Copy link

@hovox hovox commented May 13, 2018

No description provided.

@hovox
Copy link
Author

hovox commented May 13, 2018

Here is another branch where I have added LayoutManager as interface, should I merge it to this branch ?

@naqvitalha
Copy link
Collaborator

@hovox This is super cool. Let's complete externalising LayoutManager first then we'll come to this. Open it as a separate PR.
Also, if you want you can own the MasonryLayoutManager in your own repository. People needing it can import it as an external dependency.

@hovox
Copy link
Author

hovox commented May 14, 2018

I'm trying to test it. It's a little harder for me because I'm a native iOS/Android developer. Never worked with typescript.

@naqvitalha
Copy link
Collaborator

Great! Let me know if you need my help

@hovox
Copy link
Author

hovox commented May 14, 2018

Could you please check #84 issue? Without it fixed, we can't use the framework.

@naqvitalha
Copy link
Collaborator

I will be externalising layout manager soon. Your layout manager can then be independently integrated.

@MelindaFancsal
Copy link

Hi, will there be an update on this? I can't wait to see this merged.

@ign699
Copy link

ign699 commented Jul 31, 2018

Yeah would be awesome to see this merged !

@tafelito
Copy link
Contributor

tafelito commented Aug 21, 2018

@naqvitalha are you still working on externalizing the layout manager? Is there anything I can do to help?

And what's the difference btw the LayoutManager and the LayoutProvider? Wouldn't be something like the MasonryLayout possible to do with the layout provider?

@naqvitalha
Copy link
Collaborator

@tafelito Layout manager is already externalised. Check a sample layout provider: https://github.com/muskeinsingh/recyclerlistview-gridlayoutprovider. You can write a masonry one, that'll be great!

@NrqhEIcsRi004
Copy link

This feature is great, can you merge it? @naqvitalha @hovox

@pribeh
Copy link

pribeh commented Dec 22, 2018

Any update on this?

@Jose4gg
Copy link

Jose4gg commented Dec 26, 2018

Any updates with this?

@nesscx
Copy link

nesscx commented Dec 27, 2018

Any updates on this?

@ashokkumar88
Copy link

@tafelito any chance to work with masonry layout?

@lukebars
Copy link

Did you manage to complete it @hovox ?

@alexandrius
Copy link

@naqvitalha @hovox Any updates regarding MasonryLayoutProvider?

@ehsan6sha
Copy link

Here is another branch where I have added LayoutManager as interface, should I merge it to this branch ?

Do you have a snack of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.