Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite file handle, adjust file.seek() #36

Merged
merged 7 commits into from
Jan 15, 2022
Merged

rewrite file handle, adjust file.seek() #36

merged 7 commits into from
Jan 15, 2022

Conversation

Flipez
Copy link
Owner

@Flipez Flipez commented Jan 15, 2022

This closes #35

Signed-off-by: Flipez [email protected]

@Flipez Flipez added the enhancement New feature or request label Jan 15, 2022
@Flipez Flipez self-assigned this Jan 15, 2022
@vercel
Copy link

vercel bot commented Jan 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flipez/rocket-lang/BScA3ooeXFBJP8uELJtevEj3r2fh
✅ Preview: https://rocket-lang-git-improve-file-flipez.vercel.app

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #36 (d9a4ea0) into master (189458c) will decrease coverage by 0.08%.
The diff coverage is 50.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   73.65%   73.57%   -0.09%     
==========================================
  Files          26       26              
  Lines        2137     2187      +50     
==========================================
+ Hits         1574     1609      +35     
- Misses        497      513      +16     
+ Partials       66       65       -1     
Impacted Files Coverage Δ
object/file.go 50.00% <39.43%> (+2.74%) ⬆️
object/error.go 100.00% <100.00%> (ø)
stdlib/open.go 100.00% <100.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189458c...d9a4ea0. Read the comment docs.

Signed-off-by: Flipez <[email protected]>
Signed-off-by: Flipez <[email protected]>
Signed-off-by: Flipez <[email protected]>
@Flipez Flipez merged commit 24b74b8 into master Jan 15, 2022
@Flipez Flipez deleted the improve-file branch January 15, 2022 19:01
@Flipez Flipez restored the improve-file branch April 23, 2022 09:28
@Flipez Flipez deleted the improve-file branch April 23, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve file handling
2 participants