Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foreach] Add internal object iterator to fix nested loops #122

Merged
merged 2 commits into from
Sep 24, 2022
Merged

[foreach] Add internal object iterator to fix nested loops #122

merged 2 commits into from
Sep 24, 2022

Conversation

MarkusFreitag
Copy link
Collaborator

No description provided.

@MarkusFreitag MarkusFreitag linked an issue Sep 24, 2022 that may be closed by this pull request
Nested loop seems to be broken #120
Closed
@vercel
Copy link

vercel bot commented Sep 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rocket-lang ✅ Ready (Inspect) Visit Preview Sep 24, 2022 at 10:20AM (UTC)
rocket-lang-play ✅ Ready (Inspect) Visit Preview Sep 24, 2022 at 10:20AM (UTC)

@codecov
Copy link

codecov bot commented Sep 24, 2022 •
edited
Loading

Codecov Report

Merging #122 (08ee6fb) into main (3754db4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   86.51%   86.48%   -0.04%     
==========================================
  Files         102      102              
  Lines        3411     3403       -8     
==========================================
- Hits         2951     2943       -8     
  Misses        393      393              
  Partials       67       67
Impacted Files Coverage Δ
object/object.go 89.95% <ø> (ø)
evaluator/foreach.go 82.35% <100.00%> (ø)
object/array.go 100.00% <100.00%> (ø)
object/hash.go 96.42% <100.00%> (ø)
object/integer.go 100.00% <100.00%> (ø)
object/string.go 98.11% <100.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Flipez Flipez merged commit dbee0f9 into main Sep 24, 2022
@Flipez Flipez deleted the 120-nested-loop-seems-to-be-broken branch September 24, 2022 10:29
@Flipez Flipez added the enhancement New feature or request label Sep 24, 2022
@Flipez Flipez added bug Something isn't working and removed enhancement New feature or request labels Oct 30, 2022
@Flipez Flipez changed the title introduce an object iterator [foreach] Add internal object iterator to fix nested loops Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flipez Flipez Awaiting requested review from Flipez Flipez is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested loop seems to be broken
2 participants
@MarkusFreitag @Flipez