Feature/performance improvements #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are some constant strings and constant NSRegularExpressions.
This results in a lower high-water mark for memory usage.
|
Nice work, thanks. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves performance and has a lower high-water mark for memory usage.
The unit tests take about half the time to run as before, due to moving the string and NSRegularExpression objects out of the code run for each line.
The unit tests have a lower memory usage due to the autorelease pool. This kind of parser that runs until completion in an unbounded way on a background thread is a classic case where an autorelease pool reduces the high-water-mark.