Make BartyCrouch fast again #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it was commented out in this commit whose message doesn't explain why it was commented out, but it was during the big refactoring, so I'm guessing there was a problem either with builds or tests failing. Since the tests seem to be passing though, it looks good to me. You probably solved the issue with the Thanks for tackling this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #128. The only change is that the line number is no longer resolved by each match individually, instead, a linebreak → index map is created once per file, that can then be used by each individual match to get the corresponding line quickly.
When adjusting the line algorithm, I noticed that this was actually already implemented before, but then commented out for some reason. I guess it's still valid to take this approach again, as this resolves the huge speed problem present since Xcode 10.2.