Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new line on every translation after normalize #251

Closed
ivan-gaydamakin opened this issue May 2, 2022 · 2 comments · Fixed by #254
Closed

Add new line on every translation after normalize #251

ivan-gaydamakin opened this issue May 2, 2022 · 2 comments · Fixed by #254

Comments

@ivan-gaydamakin
Copy link

Problem Statement

I have file like:

"account" = "Account";
"top" = "Top";
"movie" = "Movie";

When I made "normalize" I got:

"account" = "Account";

"top" = "Top";

"movie" = "Movie";

Suggested Solution

Maybe add some param for "normalize" step, like "with_new_line=false"?

@Jeehut
Copy link
Member

Jeehut commented May 3, 2022

@ivan-gaydamakin Thank you for that suggestion. That's actually a nice idea and should be easy enough to implement. Do you want to tackle the implementation yourself, maybe? You'd just need to add a new param here, pass that down to the StringsFileUpdater and adjust the separator in this line from "\n\n" to "\n" when your option is active.

I might have a look into that myself, too, but I can't promise you any timeline right now ...

@FlineDevPublic
Copy link
Collaborator

@ivan-gaydamakin Thank you for the suggestion again, I just implemented this during my live stream and published a new version (4.11.0) where you should find the new option separateWithEmptyLine for various options (see README) which you can set all to false to get rid of the empty line. I hope this is what you were looking for and works (not tested, actually, but should work).


This comment was written during my regular Open Source live stream on Twitch. Follow me there to support my work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants