Max Larionov - Github-team-remover progress(Finished.) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxinspace
changed the title
| Remover::List.new(github).unused_teams.each do |team| | ||
| puts team.name | ||
| Remover::List.new(github).unused_teams.each do |unused_team| | ||
| puts " |
There was a problem hiding this comment.
@des1tro could you please create separate class for reporting this information?
Remover::Report.new(unused_team).report
| Remover::List.new(github).unused_teams.each do |team| | ||
| puts team.name | ||
| puts 'Unused teams:'.colorize(color) | ||
| if verbose? |
There was a problem hiding this comment.
Please create separata class for outputting invormation.
Logic should be incapsulated there.
There was a problem hiding this comment.
ok, will do it today and global refactoring.
There was a problem hiding this comment.
Got really huge troubles with making another class, code not working on my PC, but works on another.
maxinspace
changed the title
maxinspace
changed the title
Updated readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished. Everything works and fine.
description commit #2 Added coloring text as --c color. Will refactor it into another class after finishing --verbose.
gem colorize is working fine.
description commit #1 Made yet not working class commander, where all logic for commands is going to be, added gem colorize for further coloring, and now terminal shows amount of users and repos.