Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate orientation and fail fast #991

Merged
merged 8 commits into from
Aug 14, 2020

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Aug 13, 2020

Fail fast if the Orientation is misspelt for runs
Fixes #928

Test Plan

How do we know the code works?
It has been unit tested.

Checklist

  • Documented
  • Unit tested
  • release_notes.md updated

@Sloox Sloox self-assigned this Aug 13, 2020
@Sloox Sloox force-pushed the #928-device-orientation-misspell-fast-fail branch from 003107d to 72bf292 Compare August 13, 2020 17:47
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solution, nice!
I am wondering if we could print more detailed info about the device with misspelled orientation. In case when flank user has like 5 or more devices in the config file...just thinking

@pawelpasterz
Copy link
Contributor

pawelpasterz commented Aug 13, 2020

And I've just noticed that gcloud returns with exit code 1 (flank 2) for the same misspelled orientation

@Sloox
Copy link
Contributor Author

Sloox commented Aug 14, 2020

I like the solution, nice!
I am wondering if we could print more detailed info about the device with misspelled orientation. In case when flank user has like 5 or more devices in the config file...just thinking

What information actually would be important, just the devices that have misspelt orientations?

@Sloox Sloox closed this Aug 14, 2020
@Sloox Sloox reopened this Aug 14, 2020
@Sloox Sloox requested a review from adamfilipow92 August 14, 2020 13:05
@Sloox Sloox merged commit 6503738 into master Aug 14, 2020
@Sloox Sloox deleted the #928-device-orientation-misspell-fast-fail branch August 14, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fast fail when device orientation is misspelled
4 participants