-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate orientation and fail fast #991
Conversation
003107d
to
72bf292
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the solution, nice!
I am wondering if we could print more detailed info about the device with misspelled orientation. In case when flank user has like 5 or more devices in the config file...just thinking
And I've just noticed that |
What information actually would be important, just the devices that have misspelt orientations? |
…ror code inline with gcloud
Fail fast if the Orientation is misspelt for runs
Fixes #928
Test Plan
Checklist