Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add versions description command for ios and android #988

Merged
merged 6 commits into from
Aug 14, 2020

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Aug 12, 2020

Fixes #975

Test Plan

How do we know the code works?

When run


flank firebase test android|ios versions describe VERSION_ID

flank should return output like gcloud cli when execute


gcloud alpha firebase test android|ios versions describe VERSION_ID

example for flank firebase test android versions describe 28


apiLevel: 28
codeName: Pie
id: '28'
releaseDate:
  day: 6
  month: 8
  year: 2018
versionString: 9.x

example for flank firebase test ios versions describe 11.2


id: '11.2'
majorVersion: 11
minorVersion: 2
supportedXcodeVersionIds:
- 10.2.1
- 10.3
- 11.0
- 11.1
- 11.2.1
- 11.3.1
tags:
- default

example for the wrong VERSION_ID flank firebase test android versions describe test


ERROR: 'test' is not a valid OS version

Additional informations

Some supportedXcodeVersionIds is returned in single quotes on describe command like:


id: '11.2'
majorVersion: 11
minorVersion: 2
supportedXcodeVersionIds:
- 10.2.1
- '10.3'
- '11.0'
- '11.1'
- 11.2.1
- 11.3.1
tags:
- default


Api returns all versions without quotes so I cannot determine what version should in quotes. I asked on test-lab slack to get more info.

Checklist

  • Unit tested
  • release_notes.md updated

@adamfilipow92 adamfilipow92 changed the title Add versions description command for ios and android feat: add versions description command for ios and android Aug 12, 2020
@adamfilipow92 adamfilipow92 marked this pull request as ready for review August 12, 2020 14:32
@adamfilipow92 adamfilipow92 self-assigned this Aug 12, 2020
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For incorrect version, gcloud ends run with exit code 1 where flank's s 0. I think we should also reflect this.

@adamfilipow92
Copy link
Contributor Author

adamfilipow92 commented Aug 13, 2020

For incorrect version, gcloud ends run with exit code 1 where flank's s 0. I think we should also reflect this.

Done

ERROR: 'test' is not a valid OS version

Process finished with exit code 1

@adamfilipow92 adamfilipow92 force-pushed the add-versions-describe-command branch from 47ee588 to 56bdc83 Compare August 13, 2020 13:31
@pawelpasterz pawelpasterz merged commit 654421f into master Aug 14, 2020
@pawelpasterz pawelpasterz deleted the add-versions-describe-command branch August 14, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ios/android versions describe command
3 participants