-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebaseopensource.com addition #978
Conversation
.opensource/project.json
Outdated
"content": "README.md", | ||
"pages" : ["faq.md", "contributing.md", "release_notes.md"], | ||
"related": [] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm above or below the bracket? @jan-gogo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below, it is visible if you open Files changed
tab
Here you have explanation https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below, it is visible if you open
Files changed
tabHere you have explanation https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file
Interesting replies, I have had in the past debates about this but have not seen it from that perspective. I added it to intellij on auto save file as was commented (but now deleted) recommendation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that delete I recommended enable in IntelliJ
Editor->General->Save File->Ensure an empty line at the end of a file on Save
Added .opensource for firebaseopensource
There is still a requirement for the description to be updated with an issue attached to the firebaseopensource github.
Fixes #860
Test Plan
Checklist