Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebaseopensource.com addition #978

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Firebaseopensource.com addition #978

merged 3 commits into from
Aug 11, 2020

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Aug 11, 2020

Added .opensource for firebaseopensource
There is still a requirement for the description to be updated with an issue attached to the firebaseopensource github.
Fixes #860

Test Plan

How do we know the code works?
It will appear on the firebaseopensource.com website
.

Checklist

  • Documented
  • release_notes.md updated

"content": "README.md",
"pages" : ["faq.md", "contributing.md", "release_notes.md"],
"related": []
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm above or below the bracket? @jan-gogo

Copy link
Contributor

@jan-goral jan-goral Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below, it is visible if you open Files changed tab

Here you have explanation https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below, it is visible if you open Files changed tab

Here you have explanation https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file

Interesting replies, I have had in the past debates about this but have not seen it from that perspective. I added it to intellij on auto save file as was commented (but now deleted) recommendation.

Copy link
Contributor

@adamfilipow92 adamfilipow92 Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that delete I recommended enable in IntelliJ
Editor->General->Save File->Ensure an empty line at the end of a file on Save

jan-goral
jan-goral previously approved these changes Aug 11, 2020
adamfilipow92
adamfilipow92 previously approved these changes Aug 11, 2020
@Sloox Sloox dismissed stale reviews from adamfilipow92 and jan-goral via d7067cb August 11, 2020 11:11
@Sloox Sloox merged commit 43c1635 into master Aug 11, 2020
@Sloox Sloox deleted the #860-firebaseopensource branch August 11, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding to firebaseopensource.com
3 participants