Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing release version #972

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Aug 10, 2020

Fixes #961

Test Plan

How do we know the code works?

Release version should correctly print version after run command flank --version

Checklist

  • release_notes.md updated

@bootstraponline
Copy link
Contributor

$ java -jar flank.jar --version
version: v20.07.0
revision: 02bca2797b2d6c1ce4bba95a12428d5a49cc8f63

@piotradamczyk5 can you confirm this is what the version format looks like from GitHub Actions? I posted an example of what we had on Bitrise.

@piotradamczyk5
Copy link
Contributor Author

piotradamczyk5 commented Aug 10, 2020

$ java -jar flank.jar --version
version: v20.07.0
revision: 02bca2797b2d6c1ce4bba95a12428d5a49cc8f63

@piotradamczyk5 can you confirm this is what the version format looks like from GitHub Actions? I posted an example of what we had on Bitrise.

According to #961 description, I skipped leading v in version number, rest is the same as before. Should leading v for version be included in version name?

@piotradamczyk5 piotradamczyk5 force-pushed the #961-fix-flank-release-version branch from dadec4b to 33c0cd0 Compare August 10, 2020 17:00
@bootstraponline
Copy link
Contributor

bootstraponline commented Aug 10, 2020

According to #961 description, I skipped leading v in version number, rest is the same as before. Should leading v for version be included in version name?

Thanks, yeah I had the wrong version on the ticket. We should display with the v in the version number when printing to end users. The only time we drop the v is when publishing to a maven repository.

@piotradamczyk5
Copy link
Contributor Author

According to #961 description, I skipped leading v in version number, rest is the same as before. Should leading v for version be included in version name?

Thanks, yeah I had the wrong version on the ticket. We should display with the v in the version number when printing to end users. The only time we drop the v is when publishing to a maven repository.

Fixed as requested

jan-goral
jan-goral previously approved these changes Aug 11, 2020
@piotradamczyk5 piotradamczyk5 merged commit e5a6093 into master Aug 11, 2020
@piotradamczyk5 piotradamczyk5 deleted the #961-fix-flank-release-version branch August 11, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Flank v20.08.0 release version
4 participants