-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix printing release version #972
Conversation
@piotradamczyk5 can you confirm this is what the version format looks like from GitHub Actions? I posted an example of what we had on Bitrise. |
According to #961 description, I skipped leading |
dadec4b
to
33c0cd0
Compare
Thanks, yeah I had the wrong version on the ticket. We should display with the v in the version number when printing to end users. The only time we drop the v is when publishing to a maven repository. |
Fixed as requested |
87e19d8
4991ff0
to
87e19d8
Compare
Fixes #961
Test Plan
Release version should correctly print version after run command
flank --version
Checklist