-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Flood of snapshot releases #970
Merged
piotradamczyk5
merged 3 commits into
master
from
#960-fixing-flood-of-snapshot-releases
Aug 11, 2020
Merged
Fixing Flood of snapshot releases #970
piotradamczyk5
merged 3 commits into
master
from
#960-fixing-flood-of-snapshot-releases
Aug 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
changed the title
Fixing Flood of snapshot releses
Fixing Flood of snapshot releases
Aug 10, 2020
piotradamczyk5
requested review from
adamfilipow92,
bootstraponline,
jan-goral,
pawelpasterz and
Sloox
August 10, 2020 12:56
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
============================================
+ Coverage 81.36% 81.42% +0.05%
- Complexity 673 674 +1
============================================
Files 206 206
Lines 3746 3746
Branches 569 569
============================================
+ Hits 3048 3050 +2
+ Misses 395 394 -1
+ Partials 303 302 -1 |
bootstraponline
previously approved these changes
Aug 10, 2020
bootstraponline
previously approved these changes
Aug 10, 2020
piotradamczyk5
force-pushed
the
#960-fixing-flood-of-snapshot-releases
branch
from
August 10, 2020 17:01
1f95cf5
to
f8f498d
Compare
bootstraponline
previously approved these changes
Aug 11, 2020
jan-goral
previously approved these changes
Aug 11, 2020
piotradamczyk5
dismissed stale reviews from jan-goral and bootstraponline
via
August 11, 2020 09:22
ceadf5a
piotradamczyk5
force-pushed
the
#960-fixing-flood-of-snapshot-releases
branch
from
August 11, 2020 09:22
f8f498d
to
ceadf5a
Compare
pawelpasterz
approved these changes
Aug 11, 2020
adamfilipow92
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960
Test Plan
Old
flank_snapshot
releasees are removed before publishing new oneChecklist