-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement network-profiles describe feature #964
Conversation
defaultValue = "", | ||
description = ["The network profile to describe, found" + | ||
" using \$ gcloud beta firebase test network-profiles list."]) | ||
var profile: String = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
profile
-> profileId
|
||
private const val UNABLE = "[Unable to fetch]" | ||
|
||
private fun Any?.toStringOrEmpty() = this?.toString() ?: UNABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toStringOrEmpty
-> toStringOrUnableToFetch
or toStringOrUnable
ac7e7d2
to
dd88710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should use continuation indent from the official style guide.
https://kotlinlang.org/docs/reference/code-style-migration-guide.html
Maybe we all should use |
I have no experience with |
paramLabel = "PROFILE_ID", | ||
defaultValue = "", | ||
description = ["The network profile to describe, found" + | ||
" using \$ gcloud beta firebase test network-profiles list."]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's should be
gcloud beta firebase test network-profiles describe
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, the description states that we need to provide profileId
which we can get from gcloud beta firebase test network-profiles list
. So it's like -- 'first find id from the list (using this command) and then pass it as parameter'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, ok thanks!
b25bdad
to
e56f0da
Compare
👍 I am for linter. |
Installation is super easy:
and later on |
Fixes #963
Test Plan
Run
flank network-profiles describe LTE
and see the result:Compare it with
gcloud alpha firebase test network-profiles describe LTE
outputChecklist