Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make table text left aligned #962

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Make table text left aligned #962

merged 3 commits into from
Aug 10, 2020

Conversation

pawelpasterz
Copy link
Contributor

Fixes #958

Test Plan

How do we know the code works?

Text for any list option (example: flank android locales list) is left aligned. Same as for gcloud

Checklist

  • release_notes.md updated

@pawelpasterz pawelpasterz self-assigned this Aug 9, 2020
bootstraponline
bootstraponline previously approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@bootstraponline bootstraponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed text is left aligned, nice work 🙂

@pawelpasterz pawelpasterz merged commit 9dcad04 into master Aug 10, 2020
@pawelpasterz pawelpasterz deleted the left-align-table-text branch August 10, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@bootstraponline bootstraponline bootstraponline left review comments

Assignees

@pawelpasterz pawelpasterz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Left align Flank output to match gcloud
4 participants
@pawelpasterz @bootstraponline @adamfilipow92 @piotradamczyk5