Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version printing on Flank release #952

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Fix version printing on Flank release #952

merged 2 commits into from
Aug 7, 2020

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Aug 7, 2020 •
edited
Loading

Fixes #951

Change param runningOnBitrise to more generic runningOnCI

Test Plan

How do we know the code works?
Need to run a build to check the version update.
.

Checklist

  • release_notes.md updated

@Sloox Sloox self-assigned this Aug 7, 2020
piotradamczyk5
piotradamczyk5 approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job

@Sloox Sloox merged commit 8566004 into master Aug 7, 2020
@Sloox Sloox deleted the 951-fix-version-printing-flank branch August 7, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@jan-goral jan-goral Awaiting requested review from jan-goral

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@Sloox Sloox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix version printing on Flank release
2 participants
@Sloox @piotradamczyk5