Fix crash when --legacy-junit-result set #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfilipow92
requested review from
pawelpasterz,
bootstraponline,
piotradamczyk5,
jan-goral and
Sloox
adamfilipow92
force-pushed
the
947-fix-legacy-junit-flag
branch
from
2cb5355 to
19863f6
Compare
| private fun getWebLink(matrices: MatrixMap, xmlFile: File): String = xmlFile.getMatrixPath(matrices.runPath) | ||
| ?.let { path -> | ||
| matrices.map.values.firstOrNull { savedMatrix -> savedMatrix.gcsPath.endsWith(path) }?.webLink | ||
| ?: "".also { println("WARNING: Matrix path not found in JSON. $path") } |
There was a problem hiding this comment.
Could you extract this to separate method for better readability?
piotradamczyk5
approved these changes
Aug 7, 2020
Sloox
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947
Test Plan
When using --legacy-junit-result flank, shouldn't throw an exception.
Checklist