#932 Added tests for flank scripts #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val (_, actualException) = result.mapClientError { expectedException } | ||
|
|
||
| // then | ||
|
|
There was a problem hiding this comment.
fixed 👍 and also added detekt to project with the same configuration as flank
piotradamczyk5
requested review from
adamfilipow92,
bootstraponline,
jan-goral,
pawelpasterz and
Sloox
jan-goral
reviewed
Aug 7, 2020
piotradamczyk5
force-pushed
the
#932-added-tests
branch
from
2ae372c to
cc352ac
Compare
piotradamczyk5
force-pushed
the
#932-added-tests
branch
from
cc352ac to
ba5c281
Compare
jan-goral
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #932
Test Plan
Tests are available for
flank-scripts.There is not workflow dedicated to run tests on
flank-scriptsChecklist