-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run *list commands when flank.yml not found should display right output #939
Run *list commands when flank.yml not found should display right output #939
Conversation
66488aa
to
7bc2061
Compare
...ner/src/main/kotlin/ftl/cli/firebase/test/android/configuration/AndroidLocalesListCommand.kt
Show resolved
Hide resolved
*--xctestrun-file*=_<xctestrunFile>_:: | ||
The path to an .xctestrun file that will override any .xctestrun file contained in the --test package. Because the .xctestrun file contains environment variables along with test methods to run and/or ignore, this can be useful for customizing or sharding test suites. The given path may be in the local filesystem or in Google Cloud Storage using a URL beginning with gs://. | ||
|
||
*--xcode-version*=_<xcodeVersion>_:: | ||
The version of Xcode that should be used to run an XCTest. Defaults to the latest Xcode version supported in Firebase Test Lab. This Xcode version must be supported by all iOS versions selected in the test matrix. | ||
|
||
*--test*=_<test>_:: | ||
The path to the test package (a zip file containing the iOS app and XCTest files). The given path may be in the local filesystem or in Google Cloud Storage using a URL beginning with gs://. Note: any .xctestrun file in this zip file will be ignored if --xctestrun-file is specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, all theses small changes are from the auto doc generation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, they generate different output for same data 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, on every build, we have generated docs with changes like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should disable the doc generation by default until this is fixed.
@Sloox do you want to handle this contribution?
I think you just have to comment out
flank/test_runner/build.gradle.kts
Lines 284 to 286 in 5ea15cf
tasks.assemble { | |
dependsOn(processCliAsciiDoc) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bootstraponline Sure. is there an issue surrounding this so i can tag the branch correctly? or is a simple "Disable doc generation" sufficent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is small enough that we don't need an issue 🙂 "Disable doc generation" sounds great!
26c6fe6
b7c4988
to
26c6fe6
Compare
Fixes #925
Test Plan
Try run flank commands for
, without flank.yml this should display lists instead of
flank.yml
not foundChecklist