Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run *list commands when flank.yml not found should display right output #939

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Aug 5, 2020

Fixes #925

Test Plan

How do we know the code works?

Try run flank commands for

models
orientations
locales
test-environment
network

, without flank.yml this should display lists instead of flank.yml not found

Checklist

  • Unit tested
  • release_notes.md updated

@adamfilipow92 adamfilipow92 self-assigned this Aug 5, 2020
@adamfilipow92 adamfilipow92 force-pushed the 925-dont-fail-when-using-lists-commands-without-flank-config branch from 66488aa to 7bc2061 Compare August 5, 2020 13:59
@adamfilipow92 adamfilipow92 marked this pull request as ready for review August 5, 2020 14:07
*--xctestrun-file*=_<xctestrunFile>_::
The path to an .xctestrun file that will override any .xctestrun file contained in the --test package. Because the .xctestrun file contains environment variables along with test methods to run and/or ignore, this can be useful for customizing or sharding test suites. The given path may be in the local filesystem or in Google Cloud Storage using a URL beginning with gs://.

*--xcode-version*=_<xcodeVersion>_::
The version of Xcode that should be used to run an XCTest. Defaults to the latest Xcode version supported in Firebase Test Lab. This Xcode version must be supported by all iOS versions selected in the test matrix.

*--test*=_<test>_::
The path to the test package (a zip file containing the iOS app and XCTest files). The given path may be in the local filesystem or in Google Cloud Storage using a URL beginning with gs://. Note: any .xctestrun file in this zip file will be ignored if --xctestrun-file is specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, all theses small changes are from the auto doc generation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, they generate different output for same data 😞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, on every build, we have generated docs with changes like that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should disable the doc generation by default until this is fixed.

@Sloox do you want to handle this contribution?

I think you just have to comment out

tasks.assemble {
dependsOn(processCliAsciiDoc)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bootstraponline Sure. is there an issue surrounding this so i can tag the branch correctly? or is a simple "Disable doc generation" sufficent?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is small enough that we don't need an issue 🙂 "Disable doc generation" sounds great!

@piotradamczyk5 piotradamczyk5 self-requested a review August 5, 2020 14:41
piotradamczyk5
piotradamczyk5 previously approved these changes Aug 5, 2020
Sloox
Sloox previously approved these changes Aug 5, 2020
@adamfilipow92 adamfilipow92 dismissed stale reviews from Sloox and piotradamczyk5 via 26c6fe6 August 5, 2020 15:32
@adamfilipow92 adamfilipow92 force-pushed the 925-dont-fail-when-using-lists-commands-without-flank-config branch from b7c4988 to 26c6fe6 Compare August 5, 2020 15:32
@piotradamczyk5 piotradamczyk5 self-requested a review August 6, 2020 08:48
@adamfilipow92 adamfilipow92 merged commit e1637b7 into master Aug 6, 2020
@adamfilipow92 adamfilipow92 deleted the 925-dont-fail-when-using-lists-commands-without-flank-config branch August 6, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

locales, models, test-environment not working without config file.
5 participants