Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test artifacts monorepo #916

Merged
merged 7 commits into from
Jul 30, 2020
Merged

Test artifacts monorepo #916

merged 7 commits into from
Jul 30, 2020

Conversation

jan-goral
Copy link
Contributor

Fixes #898

Test Plan

How do we know the code works?

  • ./gradlew check should pass
  • Existing build scripts for test_artifacts should work as well

Checklist

  • release_notes.md updated

@jan-goral jan-goral self-assigned this Jul 28, 2020
@jan-goral jan-goral changed the title Restructure test_app Test artifacts monorepo Jul 28, 2020
@jan-goral jan-goral marked this pull request as ready for review July 28, 2020 20:40
adamfilipow92
adamfilipow92 previously approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked ./gradlew check and ./gradlew build
All working, but android build scripts not working. I update it to the new directories structure.

@adamfilipow92 adamfilipow92 dismissed their stale review July 29, 2020 09:28

Need to check test_artifact builds

@adamfilipow92 adamfilipow92 self-assigned this Jul 29, 2020
@jan-goral jan-goral merged commit 4d052b4 into master Jul 30, 2020
@jan-goral jan-goral deleted the #898-test-artifacts-monorepo branch July 30, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 left review comments

Assignees

@jan-goral jan-goral

@adamfilipow92 adamfilipow92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move source code of test artifacts to one repo.
3 participants
@jan-goral @pawelpasterz @adamfilipow92