Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

905 - Print devices screen orientations #909

Merged
merged 7 commits into from
Jul 23, 2020

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Jul 22, 2020

Fixes #905

Test Plan

How do we know the code works?

  1. Execute flank firebase test ios|android test-environment should print on bottom screen orientation table

  2. Execute flank firebase test ios|android screen-orientations list should print screen orientation table

  3. Execute flank ios|android screen-orientations list should print screen orientation table


┌────────────────┬───────────┬─────────┐
│ ORIENTATION_ID │   NAME    │   TAG   │
├────────────────┼───────────┼─────────┤
│   landscape    │ Landscape │         │
│    portrait    │ Portrait  │ default │
│    default     │  Default  │         │
└────────────────┴───────────┴─────────┘

Checklist

  • Documented
  • Unit tested
  • release_notes.md updated
  • Solution for iOS
  • Solution for Android

@adamfilipow92 adamfilipow92 self-assigned this Jul 22, 2020
@adamfilipow92 adamfilipow92 marked this pull request as ready for review July 22, 2020 14:01
@adamfilipow92 adamfilipow92 merged commit 70475bc into master Jul 23, 2020
@adamfilipow92 adamfilipow92 deleted the 905-android-screens-orientation branch July 23, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List available screen orientation for iOS and Android
2 participants