886 Print network profiles #906

adamfilipow92 · 2020-07-21T11:12:32Z

Fixes #886

Test Plan

How do we know the code works?

Command


flank firebase test network-profiles list

and


flank network-profiles list

Should print table


┌────────────┬──────┬────────┬────────────┬───────────────────┬───────────┬───────┐
│ PROFILE_ID │ RULE │ DELAY  │ LOSS_RATIO │ DUPLICATION_RATIO │ BANDWIDTH │ BURST │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.040s │   0.001    │                   │  16000.0  │       │
│    LTE     │ down │ 0.040s │   0.001    │                   │  16000.0  │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.060s │   0.0015   │                   │  4000.0   │       │
│  LTE-poor  │ down │ 0.060s │   0.0015   │                   │  4000.0   │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.060s │   0.001    │                   │  2000.0   │       │
│    HSPA    │ down │ 0.060s │   0.001    │                   │  4000.0   │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.100s │   0.0015   │                   │   500.0   │       │
│ HSPA-poor  │ down │ 0.100s │   0.0015   │                   │  1000.0   │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.060s │    0.02    │                   │  2000.0   │       │
│    UMTS    │ down │ 0.060s │    0.02    │                   │  2000.0   │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.090s │    0.04    │                   │   384.0   │       │
│ UMTS-poor  │ down │ 0.090s │    0.04    │                   │   384.0   │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.150s │    0.04    │                   │   384.0   │       │
│    EDGE    │ down │ 0.150s │    0.04    │                   │   384.0   │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.200s │    0.08    │                   │   96.0    │       │
│ EDGE-poor  │ down │ 0.200s │    0.08    │                   │   96.0    │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.300s │    0.08    │                   │   172.0   │       │
│    GPRS    │ down │ 0.300s │    0.08    │                   │   172.0   │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.500s │    0.1     │                   │   48.0    │       │
│ GPRS-poor  │ down │ 0.500s │    0.1     │                   │   48.0    │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.500s │    0.08    │                   │    9.6    │       │
│    GSM     │ down │ 0.500s │    0.08    │                   │    9.6    │       │
├────────────┼──────┼────────┼────────────┼───────────────────┼───────────┼───────┤
│            │  up  │ 0.600s │    0.1     │                   │    2.4    │       │
│  GSM-poor  │ down │ 0.600s │    0.1     │                   │    2.4    │       │
└────────────┴──────┴────────┴────────────┴───────────────────┴───────────┴───────┘

also


flank firebase test android|ios test-environment

should print this table at the end of the output.

WDYT

I added row separator to all tables to keep one style. In my opinion, it looks fine but on the other hand, the table with row separator takes more space. Tell me please what you think. Maybe we shouldn't add row separators to all tables.

Checklist

Unit tested
release_notes.md updated
Printing network profiles on flank firebase test network-profiles list
Printing network profiles on flank firebase test android|ios test-environment

…k profiles command

piotradamczyk5 · 2020-07-21T13:51:53Z

...nner/src/test/kotlin/ftl/cli/firebase/test/networkprofiles/NetworkProfilesListCommandTest.kt

+            } returns configurationsMock
+            every { configurationsMock.asPrintableTable() } returns ""
+            CommandLine(NetworkProfilesListCommand()).execute()
+            verify { configurationsMock.asPrintableTable() }


I think that we have response for this call-in mocked server. Could we use it somehow?

I'm not 100% sure but probably I need to mock it to check printing is executed on command run.

piotradamczyk5 · 2020-07-21T14:19:12Z

Could you add also the possibility to run table using a command
flank network-profiles list
?

piotradamczyk5 · 2020-07-21T14:26:35Z

test_runner/src/main/kotlin/ftl/cli/firebase/test/android/AndroidTestEnvironmentCommand.kt

@@ -24,6 +26,7 @@ class AndroidTestEnvironmentCommand : Runnable {
        println(devicesCatalogAsTable(AndroidArgs.load(Paths.get(configPath)).project))
        println(supportedVersionsAsTable(AndroidArgs.load(Paths.get(configPath)).project))
        println(providedSoftwareAsTable())
+        println(GcTesting.networkConfiguration().asPrintableTable())


Could you update description to :

header = ["Print available devices, OS versions, provided software list and network configuration to test against"], description = ["Print available Android devices, Android OS versions list, provided software and network configuration to test against"],

?

piotradamczyk5 · 2020-07-21T14:27:11Z

test_runner/src/main/kotlin/ftl/cli/firebase/test/ios/IosTestEnvironmentCommand.kt

@@ -24,6 +26,7 @@ class IosTestEnvironmentCommand : Runnable {
        println(devicesCatalogAsTable(IosArgs.load(Paths.get(configPath)).project))
        println(softwareVersionsAsTable(IosArgs.load(Paths.get(configPath)).project))
        println(providedSoftwareAsTable())
+        println(GcTesting.networkConfiguration().asPrintableTable())


Could you update description to :

header = ["Print available devices, OS versions, provided software list and network configuration to test against"], description = ["Print available iOS devices, iOS OS versions list, provided software and network configuration to test against"],

?

piotradamczyk5 · 2020-07-21T14:29:32Z

WDYT
I added row separator to all tables to keep one style. In my opinion, it looks fine but on the other hand, the table with row separator takes more space. Tell me please what you think. Maybe we shouldn't add row separators to all tables.

For me defaults separator should not be printed cause tables become larger (readability is a plus, but the size is a minus :( )

…code style on printing network configuration

adamfilipow92 · 2020-07-21T14:52:12Z

WDYT
I added row separator to all tables to keep one style. In my opinion, it looks fine but on the other hand, the table with row separator takes more space. Tell me please what you think. Maybe we shouldn't add row separators to all tables.
For me defaults separator should not be printed cause tables become larger (readability is a plus, but the size is a minus :( )

So we thinking the same. I added a table style option and set default style without rows separation. Thanks for your feedback!

piotradamczyk5 · 2020-07-21T15:13:50Z

Great work 👍

adamfilipow92 marked this pull request as ready for review July 21, 2020 13:10

adamfilipow92 self-assigned this Jul 21, 2020

adamfilipow92 requested review from piotradamczyk5, jan-goral and bootstraponline and removed request for piotradamczyk5 July 21, 2020 13:10

adamfilipow92 added 5 commits July 21, 2020 15:48

Add list of avaliable network configuration to ios android and networ…

ae4669b

…k profiles command

Add results in single table

bbd8777

Namming changes and some changes in code on printing line separator

c711f62

Update release_notes.md

eef27e3

Updated: dosc, tests, detekt

1727ec1

adamfilipow92 force-pushed the 886-all-network branch from 7de4d53 to 1727ec1 Compare July 21, 2020 13:49

piotradamczyk5 reviewed Jul 21, 2020

View reviewed changes

adamfilipow92 marked this pull request as draft July 21, 2020 14:25

piotradamczyk5 reviewed Jul 21, 2020

View reviewed changes

adamfilipow92 added 2 commits July 21, 2020 16:44

Set default table style to no row separator, update tests and change …

91d7fe9

…code style on printing network configuration

detekt fix

93ce35e

Add flank network-profiles list command

79573dd

adamfilipow92 marked this pull request as ready for review July 21, 2020 15:08

piotradamczyk5 self-requested a review July 21, 2020 15:14

update docs

bdf9047

piotradamczyk5 approved these changes Jul 21, 2020

View reviewed changes

adamfilipow92 merged commit bc7097d into master Jul 21, 2020

adamfilipow92 deleted the 886-all-network branch July 21, 2020 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

886 Print network profiles #906

886 Print network profiles #906

adamfilipow92 commented Jul 21, 2020 •

edited

Loading

piotradamczyk5 Jul 21, 2020

adamfilipow92 Jul 21, 2020

piotradamczyk5 commented Jul 21, 2020

piotradamczyk5 Jul 21, 2020 •

edited

Loading

adamfilipow92 Jul 21, 2020

piotradamczyk5 Jul 21, 2020

adamfilipow92 Jul 21, 2020

piotradamczyk5 commented Jul 21, 2020

adamfilipow92 commented Jul 21, 2020

piotradamczyk5 commented Jul 21, 2020

886 Print network profiles #906

886 Print network profiles #906

Conversation

adamfilipow92 commented Jul 21, 2020 • edited Loading

Test Plan

WDYT

Checklist

piotradamczyk5 Jul 21, 2020

Choose a reason for hiding this comment

adamfilipow92 Jul 21, 2020

Choose a reason for hiding this comment

piotradamczyk5 commented Jul 21, 2020

piotradamczyk5 Jul 21, 2020 • edited Loading

Choose a reason for hiding this comment

adamfilipow92 Jul 21, 2020

Choose a reason for hiding this comment

piotradamczyk5 Jul 21, 2020

Choose a reason for hiding this comment

adamfilipow92 Jul 21, 2020

Choose a reason for hiding this comment

piotradamczyk5 commented Jul 21, 2020

adamfilipow92 commented Jul 21, 2020

piotradamczyk5 commented Jul 21, 2020

adamfilipow92 commented Jul 21, 2020 •

edited

Loading

piotradamczyk5 Jul 21, 2020 •

edited

Loading