Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#835 Added printing iOS devices #895

Merged
merged 2 commits into from
Jul 17, 2020
Merged

#835 Added printing iOS devices #895

merged 2 commits into from
Jul 17, 2020

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #835

Test Plan

How do we know the code works?

Use on of a new CLI option to test this PR:

  • flank firebase test ios models list or flank ios models list - print iOS available devices to test against
Sample iOS models list output:

┌─────────────┬───────────────────────┬─────────────┬────────────────────────┬──────────────────────────────────┐
│  MODEL_ID   │      MODEL_NAME       │ RESOLUTION  │     OS_VERSION_IDS     │               TAGS               │
├─────────────┼───────────────────────┼─────────────┼────────────────────────┼──────────────────────────────────┤
│    ipad5    │ iPad (5th generation) │ 2048 x 1536 │       11.2, 12.0       │         deprecated=11.2          │
│  ipadmini4  │      iPad mini 4      │ 2048 x 1536 │       11.2, 12.0       │         deprecated=11.2          │
│ ipadpro_105 │ iPad Pro (10.5-inch)  │ 2224 x 1668 │          11.2          │         deprecated=11.2          │
│  iphone11   │       iPhone 11       │ 1792 x 828  │          13.3          │                                  │
│ iphone11pro │     iPhone 11 Pro     │ 2436 x 1125 │          13.3          │                                  │
│   iphone6   │       iPhone 6        │ 1334 x 750  │          11.4          │         deprecated=11.4          │
│  iphone6s   │       iPhone 6s       │ 1334 x 750  │ 10.3, 11.2, 11.4, 12.0 │ deprecated=10.3, deprecated=11.2 │
│   iphone7   │       iPhone 7        │ 1334 x 750  │ 11.2, 11.4, 12.0, 12.3 │         deprecated=11.2          │
│ iphone7plus │     iPhone 7 Plus     │ 1920 x 1080 │    11.2, 11.4, 12.0    │         deprecated=11.2          │
│   iphone8   │       iPhone 8        │ 1334 x 750  │    11.2, 11.4, 12.0    │     deprecated=11.2, default     │
│ iphone8plus │     iPhone 8 Plus     │ 1920 x 1080 │ 11.2, 11.4, 12.0, 12.3 │         deprecated=11.2          │
│  iphonese   │       iPhone SE       │ 1136 x 640  │ 11.2, 11.4, 12.0, 12.3 │         deprecated=11.2          │
│   iphonex   │       iPhone X        │ 2436 x 1125 │ 11.2, 11.4, 12.0, 12.3 │         deprecated=11.2          │
│  iphonexr   │       iPhone XR       │ 1792 x 828  │          13.2          │                                  │
│  iphonexs   │       iPhone XS       │ 2436 x 1125 │    12.0, 12.1, 12.3    │                                  │
│ iphonexsmax │     iPhone XS Max     │ 2688 x 1242 │    12.0, 12.1, 12.3    │                                  │
└─────────────┴───────────────────────┴─────────────┴────────────────────────┴──────────────────────────────────┘

More listing options of the test environment will be added in the next tasks

Checklist

  • printing iOS devices list
  • Documented
  • Unit tested
  • release_notes.md updated

@piotradamczyk5 piotradamczyk5 self-assigned this Jul 16, 2020
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checked, solution tested, in my opinion, everything is ok.

@piotradamczyk5 piotradamczyk5 merged commit 2edb898 into master Jul 17, 2020
@piotradamczyk5 piotradamczyk5 deleted the #835-ios-devices branch July 17, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show available devices
2 participants