Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#835 Added printing available Android software versions #894

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #835

Test Plan

How do we know the code works?

Use on of a new CLI option to test this PR:

  • flank firebase test android versions list or flank android versions list - print Android available versions to test against
Sample Android versions list output:

┌───────────────┬─────────┬─────────────┬───────────┬──────────────┬─────────┐
│ OS_VERSION_ID │ VERSION │  CODE_NAME  │ API_LEVEL │ RELEASE_DATE │  TAGS   │
├───────────────┼─────────┼─────────────┼───────────┼──────────────┼─────────┤
│      18       │  4.3.x  │ Jelly Bean  │    18     │  2013-10-03  │         │
│      19       │  4.4.x  │   KitKat    │    19     │  2014-06-02  │         │
│      21       │  5.0.x  │  Lollipop   │    21     │  2014-12-19  │         │
│      22       │  5.1.x  │  Lollipop   │    22     │  2015-04-21  │         │
│      23       │  6.0.x  │ Marshmallow │    23     │  2015-10-05  │         │
│      24       │  7.0.x  │   Nougat    │    24     │  2016-08-22  │         │
│      25       │  7.1.x  │   Nougat    │    25     │  2016-10-19  │         │
│      26       │  8.0.x  │    Oreo     │    26     │  2017-08-21  │ default │
│      27       │  8.1.x  │  Oreo MR1   │    27     │  2017-12-04  │         │
│      28       │   9.x   │     Pie     │    28     │  2018-08-06  │         │
│      29       │  10.x   │      Q      │    29     │  2019-09-03  │         │
│      30       │   11    │      R      │    30     │  2020-09-03  │         │
└───────────────┴─────────┴─────────────┴───────────┴──────────────┴─────────┘

More listing options of the test environment will be added in the next tasks

Checklist

  • printing Android software versions list
  • Documented
  • Unit tested
  • release_notes.md updated

@piotradamczyk5 piotradamczyk5 force-pushed the #835-android-software branch from 91faa32 to 0871747 Compare July 17, 2020 10:26
class AndroidVersionsListCommandTest {

@Test
fun androidVersionsListCommandOptions() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the purposes of this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked if parameters are set

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no logic under the hood. Why do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just follow testing practices from other Commands
I will remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I see. Now I found that we should change those practices. There is no reason for testing assignments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@piotradamczyk5 piotradamczyk5 merged commit b0af219 into master Jul 17, 2020
@piotradamczyk5 piotradamczyk5 deleted the #835-android-software branch July 17, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show available devices
3 participants