Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#768 Convert bitrise ubuntu workflow into GitHub actions #890

Merged

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Jul 15, 2020

Fixes #768

Test Plan

How do we know the code works?

The ubuntu-workflow runs in each PR

Checklist

  • release_notes.md updated

@piotradamczyk5 piotradamczyk5 force-pushed the #768-bitrise-ubuntu-workflow-into-github-actions branch from 3ad2ab5 to de49fab Compare July 15, 2020 14:40
@piotradamczyk5 piotradamczyk5 changed the title #768 bitrise ubuntu workflow into GitHub actions #768 Convert bitrise ubuntu workflow into GitHub actions Jul 15, 2020
@piotradamczyk5 piotradamczyk5 force-pushed the #768-bitrise-ubuntu-workflow-into-github-actions branch from de49fab to 3066325 Compare July 15, 2020 14:43
@piotradamczyk5 piotradamczyk5 self-assigned this Jul 15, 2020
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review July 15, 2020 14:48
@codecov-commenter
Copy link

Codecov Report

Merging #890 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #890      +/-   ##
============================================
- Coverage     82.80%   82.74%   -0.06%     
  Complexity      648      648              
============================================
  Files           173      173              
  Lines          3472     3472              
  Branches        514      514              
============================================
- Hits           2875     2873       -2     
  Misses          314      314              
- Partials        283      285       +2     

@bootstraponline
Copy link
Contributor

I think these binaries should be auto downloaded? We don't want to add large binaries to the repo if possible.

@piotradamczyk5
Copy link
Contributor Author

I think these binaries should be auto downloaded? We don't want to add large binaries to the repo if possible.

I think that you are right, the same is for main/resources.
I will create the ticket to add these binaries with git annex after setup it

@piotradamczyk5 piotradamczyk5 merged commit 9113bd2 into master Jul 16, 2020
@piotradamczyk5 piotradamczyk5 deleted the #768-bitrise-ubuntu-workflow-into-github-actions branch July 16, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Flank | Ubuntu Public to GitHub Actions
4 participants