-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance permission denied exception logs #875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
============================================
- Coverage 82.75% 82.72% -0.04%
Complexity 638 638
============================================
Files 172 172
Lines 3370 3386 +16
Branches 481 483 +2
============================================
+ Hits 2789 2801 +12
- Misses 311 316 +5
+ Partials 270 269 -1 |
The pull request looks great! I left some small comments about updating the wording. |
jan-goral
suggested changes
Jul 1, 2020
adamfilipow92
force-pushed
the
clean-permission-denied-exception-log
branch
from
July 2, 2020 11:59
aa61f6b
to
48a64a2
Compare
jan-goral
reviewed
Jul 3, 2020
pawelpasterz
force-pushed
the
clean-permission-denied-exception-log
branch
from
July 3, 2020 18:49
7d212cf
to
f6e8c7d
Compare
jan-goral
previously approved these changes
Jul 6, 2020
Co-authored-by: bootstraponline <[email protected]>
Co-authored-by: bootstraponline <[email protected]>
pawelpasterz
force-pushed
the
clean-permission-denied-exception-log
branch
from
July 6, 2020 19:12
c7bff59
to
c2546ac
Compare
pawelpasterz
force-pushed
the
clean-permission-denied-exception-log
branch
from
July 6, 2020 19:14
2d13bfc
to
b8c0856
Compare
jan-goral
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #874
Test Plan
1. User don't have permission to project (403)
When user don't have permission to project Flank should returns message like:
2. Project not found (404)
When project not found on firebase Flank should return message like:
3. On this two cases Flank throws FlankCommonException and exit with code: 1
Checklist