Skip @Ignore tests before send it to ftl and reapply to local JUnit Xml #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
============================================
- Coverage 81.39% 81.26% -0.14%
- Complexity 638 644 +6
============================================
Files 167 170 +3
Lines 3257 3298 +41
Branches 468 472 +4
============================================
+ Hits 2651 2680 +29
- Misses 342 354 +12
Partials 264 264 |
added 4 commits
June 15, 2020 19:52
…nd-it-to-ftl' into 852-Skip-@Ignore-tests-before-send-it-to-ftl
3 tasks
adamfilipow92
changed the title
jan-goral
reviewed
Jun 16, 2020
| args = args, | ||
| forcedShardCount = args.numUniformShards | ||
| ).run { | ||
| return@run copy( |
| forcedShardCount = args.numUniformShards | ||
| ).run { | ||
| return@run copy( | ||
| shards = this.shardChunks.filter { it.isNotEmpty() }, |
| @@ -114,14 +123,27 @@ object ReportManager { | |||
| HtmlErrorReport | |||
| ).map { it.run(matrices, testSuite, printToStdout = false, args = args) } | |||
| } | |||
| JUnitReport.run(matrices, testSuite, printToStdout = false, args = args) | |||
| JUnitReport.run(matrices, testSuite.apply { | |||
There was a problem hiding this comment.
JUnitReport.run(matrices, testSuite?.apply {
if (ignoredTestCases.isNotEmpty()) {
testsuites?.add(ignoredTestCases.toJunitTestsResults())
}
}, printToStdout = false, args = args)
piotradamczyk5
requested review from
jan-goral,
bootstraponline,
pawelpasterz and
piotradamczyk5
jan-goral
previously approved these changes
Jun 16, 2020
Co-authored-by: bootstraponline <[email protected]>
piotradamczyk5
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #852
Test Plan
Ignored test should't shows on FTL
Checklist