#787 More error messages improvements #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
adamfilipow92,
bootstraponline,
jan-goral and
pawelpasterz
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
============================================
- Coverage 80.14% 80.11% -0.03%
- Complexity 674 676 +2
============================================
Files 151 151
Lines 3087 3098 +11
Branches 443 443
============================================
+ Hits 2474 2482 +8
- Misses 336 337 +1
- Partials 277 279 +2 |
jan-goral
reviewed
Jun 2, 2020
| @@ -13,3 +14,8 @@ fun convertConfigurationErrorExceptions(missingParameterError: Exception, yaml: | |||
| missingParameterError | |||
| } | |||
| } | |||
|
|
|||
| fun convertConfigurationErrorExceptions(treeParsingException: MarkedYAMLException): Throwable { | |||
| val errorMessageBuilder = ConfigurationErrorMessageBuilder | |||
There was a problem hiding this comment.
If ConfigurationErrorMessageBuilder.invoke will be a top level function, this assignment wouldn't be needed ;).
There was a problem hiding this comment.
to make this consistent I leave this in ConfigurationErrorMessageBuilder, but changed to a single line and avoid assignment
jan-goral
reviewed
Jun 2, 2020
| @@ -0,0 +1,214 @@ | |||
| # gcloud args match the official gcloud cli | |||
| # See the docs for full gcloud details https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run | |||
There was a problem hiding this comment.
the comments are not necessary
There was a problem hiding this comment.
comments removed
added 3 commits
June 3, 2020 16:05
…sages-improvements # Conflicts: # release_notes.md
| @@ -78,6 +83,34 @@ Error node: { | |||
| Assert.assertEquals(exceptedMessage, actualMessage) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `Should properly build error message from MarkedYAMLException`() { | |||
There was a problem hiding this comment.
Rest of function names starts from lower letter.
adamfilipow92
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Test Plan
Check error messages when YAML tree is bad (example in file
flank-bad-yaml-formatting.yml)Unit tests describe current behavior
Checklist