#750 Store test results in gcloud bucket #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfilipow92
force-pushed
the
#750-Automatically-store-reports-in-gcloud-bucket
branch
from
b8c4b70 to
037497c
Compare
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
============================================
+ Coverage 81.23% 81.44% +0.21%
- Complexity 637 642 +5
============================================
Files 167 167
Lines 3240 3250 +10
Branches 463 463
============================================
+ Hits 2632 2647 +15
+ Misses 343 339 -4
+ Partials 265 264 -1 |
adamfilipow92
requested review from
jan-goral,
pawelpasterz,
bootstraponline and
piotradamczyk5
adamfilipow92
force-pushed
the
#750-Automatically-store-reports-in-gcloud-bucket
branch
from
b750b9e to
1bbf21a
Compare
jan-goral
reviewed
Jun 22, 2020
| @@ -204,6 +204,9 @@ flank: | |||
|
|
|||
| ## Enable create additional local junit result on local storage with failure nodes on passed flaky tests. | |||
| # full-junit-result: false | |||
|
|
|||
| ## Disables flank results upload on gcloud storage. | |||
| # disable-results-upload: false | |||
There was a problem hiding this comment.
Same should be in android section
There was a problem hiding this comment.
And add info about default value, thanks!
adamfilipow92
force-pushed
the
#750-Automatically-store-reports-in-gcloud-bucket
branch
from
4cde50a to
42c0032
Compare
| @@ -204,6 +204,9 @@ flank: | |||
|
|
|||
| ## Enable create additional local junit result on local storage with failure nodes on passed flaky tests. | |||
| # full-junit-result: false | |||
|
|
|||
| ## Disables flank results upload on gcloud storage. | |||
| # disable-results-upload: false | |||
There was a problem hiding this comment.
And add info about default value, thanks!
| @@ -41,5 +42,6 @@ object CostReport : IReport { | |||
| val output = generate(matrices) | |||
| if (printToStdout) print(output) | |||
| write(matrices, output, args) | |||
| GcStorage.uploadReportResult(output, args, fileName()) | |||
There was a problem hiding this comment.
Just want to confirm, we want to upload all reports or just junit's?
There was a problem hiding this comment.
I think we want to upload all reports.
| Paths.get(reportPath(matrices, args)).let { | ||
| val htmlReport = suites.createHtmlReport() | ||
| Files.write(it, htmlReport.toByteArray()) | ||
| GcStorage.uploadReportResult(htmlReport, args, it.fileName.toString()) |
There was a problem hiding this comment.
Same here, do we want to have this uploaded?
jan-goral
approved these changes
Jun 24, 2020
adamfilipow92
deleted the
#750-Automatically-store-reports-in-gcloud-bucket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750
Test Plan
-Should upload reports to gcloud bucket
Checklist