#824 Automatically convert -1 in maximum-test-shards to the maximum shard amount

[adamfilipow92]

Fixes #824

Checklist

• Unit tested
• release_notes.md updated

[codecov-commenter]

Codecov Report

Merging #825 into master will increase coverage by 0.08%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #825      +/-   ##
============================================
+ Coverage     80.02%   80.11%   +0.08%     
  Complexity      674      674              
============================================
  Files           151      151              
  Lines          3084     3087       +3     
  Branches        442      443       +1     
============================================
+ Hits           2468     2473       +5     
+ Misses          337      336       -1     
+ Partials        279      278       -1     

[pawelpasterz]

I think this implementations stands between two solutions and we should decide which way to proceed.
@bootstraponline I don't know if this is desired behavior but I think we should either 'fix' all incorrect input values or throw an error for all.
With this implementation we treat -1 with special care but how about 0, < -1 and > 50.
We could change input to the closest acceptable value and maybe print message to inform use that incorrect input was provided and how flank process it...

WDYT?

[bootstraponline]

@bootstraponline I don't know if this is desired behavior but I think we should either 'fix' all incorrect input values or throw an error for all.
With this implementation we treat -1 with special care but how about 0, < -1 and > 50.
We could change input to the closest acceptable value and maybe print message to inform use that incorrect input was provided and how flank process it...

• -1 is a special value that means use the maximum amount of shards. This is an important feature for backwards compatibility and also forwards compatibility when FTL increases the maximum shard count.
• 0 is technically a valid shard amount (equal to disabling sharding). I'm fine if this throws an exception, no strong opinions here.
• < -1 is invalid and should throw an exception
• > 50 is invalid and should throw an exception

[pawelpasterz]

I understand, thanks for response!