Add AndroidTestContext as base data for dump shards & test execution

[jan-goral]

#718
Probably will fix #818

This is refactoring of code that belongs to android-run and dumps-shards

Why those changes are important:

1. Robo and instrumentation tests was not separated clearly so I have add AndroidTestContext sealed class which holds data for specific case.
2. Some of code used for shard dumping and android test running was redundant, so I added createAndroidTestContexts function, which provides common data for shard dumping & android test running.

[codecov-commenter]

Codecov Report

Merging #817 into master will increase coverage by 1.45%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #817      +/-   ##
============================================
+ Coverage     78.30%   79.75%   +1.45%     
  Complexity      667      667              
============================================
  Files           149      148       -1     
  Lines          3014     3008       -6     
  Branches        439      435       -4     
============================================
+ Hits           2360     2399      +39     
+ Misses          374      334      -40     
+ Partials        280      275       -5     

[bootstraponline]

this looks awesome!

[jan-goral]

this looks awesome!

Thanks 👍 I still have to make sure I didn't break anything.

[jan-goral]

The additional side effect of this refactor is that now we can specify both robo test with instrumented test in one config and run it together.
Tested with following config:

gcloud:
  app: ./src/test/kotlin/ftl/fixtures/tmp/apk/app-debug.apk
  robo-script: ./src/test/kotlin/ftl/fixtures/test_app_cases/MainActivity_robo_script.json
  num-flaky-test-attempts: 2

flank:
  disable-sharding: false
  max-test-shards: 2
  num-test-runs: 1
  additional-app-test-apks:
    - test: ./src/test/kotlin/ftl/fixtures/tmp/apk/app-single-success-debug-androidTest.apk
    - test: ./src/test/kotlin/ftl/fixtures/tmp/apk/app-multiple-flaky-debug-androidTest.apk
    - test: ../test_app/apks/invalid.apk

[bootstraponline]

The additional side effect of this refactor is that now we can specify both robo test with instrumented test in one config and run it together.

That's quite nice.

[jan-goral]

Should be merged after #801

[adamfilipow92]

Can be private?

[jan-goral]

perhaps, now it could

[adamfilipow92]

In my opinion keeping curly braces is more redable

runBlocking {
            if (dumpShards)
                dumpShards(config) else
                newTestRun(config)
      }

vs

runBlocking {
            if (dumpShards) {
                dumpShards(config)
            } else {
                newTestRun(config)
            }
        }

or

override fun run() {
        if (dryRun) {
            MockServer.start()
        }
        val config = AndroidArgs.load(Paths.get(configPath), cli = this)
        runProcess(config)
    }

    private fun runProcess(config: AndroidArgs) = runBlocking {
        if (dumpShards) {
            dumpShards(config)
        } else {
            newTestRun(config)
        }
    }

Tell me what you think.

[jan-goral]

Curly braces make sense when u need to open new scope for more than one operation. Otherwise I prefer clear declarative expressions where curly braces are redundant.

[adamfilipow92]

👍

[inktomi]

I think this closed #818 but it shouldn't have. I was able to reproduce the issue on this branch.