Fix overlapping results #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good to me |
jan-goral
previously approved these changes
May 20, 2020
|
Pls update release notes :) |
Sure, it's just draft for the moment :) |
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
============================================
- Coverage 79.01% 78.90% -0.12%
+ Complexity 702 696 -6
============================================
Files 138 137 -1
Lines 2930 2891 -39
Branches 421 417 -4
============================================
- Hits 2315 2281 -34
+ Misses 343 342 -1
+ Partials 272 268 -4 |
pawelpasterz
force-pushed
the
fix-overlapping-results
branch
from
08acbb8 to
db1cc64
Compare
pawelpasterz
force-pushed
the
fix-overlapping-results
branch
from
db1cc64 to
ae5ba7d
Compare
|
@bootstraponline @jan-gogo |
jan-goral
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will break backward compatibility due to different directory structure for both gcs and local results, but is essential to fix overlapping results bug
Fixes #792
Add matrix level to directory tree structure for gcs . iOS structure remains the same.
Within this change local dir structure will be exactly the same as gcs'.
iOS path should be inlined with android once FTL introduces server side sharding for iOS.
Examples:
Android:
test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-21_07-57-00.760000_AIxU/matrix_2/NexusLowRes-28-en-portrait-shard_0results/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-21_07-57-00.760000_AIxU/matrix_2/NexusLowRes-28-en-portrait-shard_0iOS:
test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-21_08-38-22.460000_OnCd/shard_0/iphone8-11.2-en_US-portrait/results/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-21_08-38-22.460000_OnCd/shard_0/iphone8-11.2-en_US-portrait/Checklist