Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "localhost" as default for hostname to fix backward compatibility… #763

Merged
merged 2 commits into from
May 4, 2020

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented May 4, 2020

Fixes #749

Checklist

  • release_notes.md updated

@jan-goral jan-goral self-assigned this May 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #763   +/-   ##
=========================================
  Coverage     78.14%   78.14%           
  Complexity      665      665           
=========================================
  Files           125      125           
  Lines          2778     2778           
  Branches        399      399           
=========================================
  Hits           2171     2171           
  Misses          351      351           
  Partials        256      256           

@jan-goral jan-goral marked this pull request as ready for review May 4, 2020 07:08
@jan-goral jan-goral requested a review from bootstraponline May 4, 2020 07:08
Copy link
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jan-goral jan-goral merged commit f8e1b02 into master May 4, 2020
@jan-goral jan-goral deleted the 749-fix-hostname-attr-backward-compatibility branch May 4, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flank snapshot smart result report differs from current 8.1.0 breaking backward compatibilty
4 participants