Add keep file path for ios #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
============================================
+ Coverage 78.52% 78.77% +0.24%
- Complexity 664 665 +1
============================================
Files 113 113
Lines 2673 2676 +3
Branches 381 380 -1
============================================
+ Hits 2099 2108 +9
+ Misses 324 322 -2
+ Partials 250 246 -4 |
| @@ -168,6 +168,10 @@ flank: | |||
| ## Local folder to store the test result. Folder is DELETED before each run to ensure only artifacts from the new run are saved. | |||
| # local-result-dir: flank | |||
|
|
|||
| ## Keeps the full path of downloaded files. Required when file names are not unique. | |||
| ## Default: false | |||
| # keep-file-path: false | |||
There was a problem hiding this comment.
Make sure to update flank.ios.yml
https://github.com/Flank/flank/blob/master/test_runner/flank.ios.yml
There was a problem hiding this comment.
Thanks for pointing this out!
|
Thank you for working on this feature! I've downloaded the branch and ran 3 tests. The feature appears to be working as expected. 🎉
files-to-download:
- .*
keep-file-path: false
files-to-download:
- .*
keep-file-path: true
|
test_runner/flank.ios.yml
Outdated
|
|
||
| ## Keeps the full path of downloaded files. Required when file names are not unique. | ||
| ## Default: false | ||
| # keep-file-path: false |
There was a problem hiding this comment.
let's keep the newline at the end of the file
https://unix.stackexchange.com/a/18789
bootstraponline
previously approved these changes
Apr 13, 2020
bootstraponline
previously approved these changes
Apr 13, 2020
jan-goral
previously approved these changes
Apr 13, 2020
pawelpasterz
dismissed stale reviews from jan-goral and bootstraponline
via
33d55ea
bootstraponline
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705
Checklist