Fix shards calculation when there are ignored tests and shardTime is -1 #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
============================================
+ Coverage 77.56% 77.58% +0.01%
- Complexity 647 653 +6
============================================
Files 112 112
Lines 2661 2663 +2
Branches 370 372 +2
============================================
+ Hits 2064 2066 +2
Misses 357 357
Partials 240 240 |
|
@bootstraponline I've tested this solution with wide variety of apk combinations. I did not encounter this error. Let us know what do you think. |
pawelpasterz
approved these changes
Apr 7, 2020
|
This looks great! Thanks for adding a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703
Checklist