Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --dry option to android run & ios run #643

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Add --dry option to android run & ios run #643

merged 1 commit into from
Feb 29, 2020

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Feb 27, 2020 •
edited
Loading

Fixes #447

Checklist

  • Documented
  • Unit tested

@jan-goral jan-goral self-assigned this Feb 27, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@55a3039). Click here to learn what that means.
The diff coverage is 36%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #643   +/-   ##
========================================
  Coverage          ?   77.6%           
  Complexity        ?     630           
========================================
  Files             ?      83           
  Lines             ?    2518           
  Branches          ?     322           
========================================
  Hits              ?    1954           
  Misses            ?     356           
  Partials          ?     208

pawelpasterz
pawelpasterz approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for contribution!
BTW, did you check if server mock paths are not outdated? Or should we do it in another issue?

@jan-goral
Copy link
Contributor Author

LGTM -- thanks for contribution!
BTW, did you check if server mock paths are not outdated? Or should we do it in another issue?

If server pathes are outdated it wouldn't work, also tests shouldn't pass. So it's ok I guess.

@jan-goral jan-goral merged commit 2d49dd1 into master Feb 29, 2020
@jan-goral jan-goral deleted the dry-run branch February 29, 2020 20:54
@jan-goral jan-goral added Feature New Option Used to track PR with new configuration option (useful when updating fladle) labels Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bootstraponline bootstraponline bootstraponline approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

Assignees

@jan-goral jan-goral

Labels
Feature New Option Used to track PR with new configuration option (useful when updating fladle)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dry run mode for flank
4 participants
@jan-goral @codecov-io @bootstraponline @pawelpasterz