Add --keep-file-path #615
Add --keep-file-path #615
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
============================================
- Coverage 76.35% 76.31% -0.05%
- Complexity 606 610 +4
============================================
Files 81 81
Lines 2284 2297 +13
Branches 324 327 +3
============================================
+ Hits 1744 1753 +9
- Misses 323 324 +1
- Partials 217 220 +3 |
tahirhajizada
force-pushed
the
feature/preserve-original-path
branch
from
3ce5c10 to
8683736
Compare
|
Thanks for submitting a pull request! I'll take a look soon. |
README.md
Outdated
|
|
||
| ## Downloaded files preserves the original path of file. Required when file names are not unique. | ||
| ## Default: false | ||
| # preserve-original-path: false |
There was a problem hiding this comment.
Thanks for working on this! What do you think of keep-file-path for the key name?
| @@ -16,12 +17,16 @@ data class ObjPath( | |||
| val objName = parsed.getName(0).toString() | |||
| val shardName = parsed.getName(1).toString() | |||
| val deviceName = parsed.getName(2).toString() | |||
| val filePathName = if (parsed.nameCount > 4) { | |||
| parsed.subpath(3, parsed.nameCount - 1).toString() | |||
There was a problem hiding this comment.
What do you think of parsed.parent.drop(3).joinToString("/") as a way to simplify the parsed.subpath logic?
|
I'm happy to make the suggested changes if that'd be easier. |
|
I am ok with your suggestions. Makes sense. It would be nice if you apply them or I can do after 9-10 hours :) |
|
Sounds good. I'll apply the fixes in ~4 hours after work. |
Update readme with new toggle add toggle to android flank yml Add cli command and tests for preserve-original-path
bootstraponline
force-pushed
the
feature/preserve-original-path
branch
2 times, most recently
from
39a9814 to
a184d47
Compare
Rename preserveOriginalPath to keepFilePath Update release_notes.md
bootstraponline
force-pushed
the
feature/preserve-original-path
branch
from
a184d47 to
505f0d6
Compare
|
I updated, tested, and merged your pull request! Nice work. I released Flank v8.1.0 with the feature and updated the change log. Thanks for contributing. |
|
Thank you for the changes and release. Welcome. |
Fix #611