Add files-to-download

[winterDroid]

Support downloading directories after test run from the result bucket
Upgrade Guava to 25.1 due to NoSuchMethodError while running tests (see google/truth#473)
Fix missing download of PNGs after test run

[winterDroid]

Fixes #438

[codecov-io]

Codecov Report

Merging #441 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #441      +/-   ##
============================================
- Coverage     79.16%   79.04%   -0.13%     
- Complexity      619      639      +20     
============================================
  Files            69       69              
  Lines          1781     1885     +104     
  Branches        271      303      +32     
============================================
+ Hits           1410     1490      +80     
- Misses          194      216      +22     
- Partials        177      179       +2

[Macarse]

@winterDroid What's the diff between directories-to-download and --directories-to-pull from #408?

[winterDroid]

This one will download the directories specified from the bucket to your local storage, the other one downloads from the device to the bucket

[Macarse]

Oh, I see. I guess the cmd is not part of gcloud and that's why it was not part of #365.
I wonder if we should add bucket to the cmd somehow to avoid confusion. Something like directories-to-download-from-bucket. wdyt?

[winterDroid]

I thought about that, but I think the problem with that is that it is hard to know the full path.. Maybe it would be better to have it files-to-download which takes a regex and not just a string..

[Macarse]

I tested this and it works as expected. I will test this on iOS tomorrow but it should work.
@bootstraponline plz review and merge 👍

[bootstraponline]

I'll take a look when I'm back at work tomorrow.

[bootstraponline]

Auto downloading pngs was intentionally removed because it's slow and there's no way to disable the behavior. I think the new dir-to-download feature will allow users to opt into downloading what they want (pngs included).

[bootstraponline]

Maybe it would be better to have it files-to-download which takes a regex and not just a string..

I think that's a great suggestion. I updated the code to work on a regex that downloads files.

[Macarse]

Tested on iOS and Android. Merge! 👍

[bootstraponline]

The feature has been merged into Flank. It'll be part of the v4.2 release. Thanks for contributing!