fix: bringing integration tests back to life #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FTL recently deprecated iphone8/12, so integration tests have been failing * Updated local copy of FTL catalog to recent version * Replaced iOS integration test app EarlGreyExample with FlankExampleTest EarlGreyExample is failing on newer OS/xcode. Current copy is based on EarlGreyExample v1, which is no longer maintained. V2 is pretty hard to get up and running, so switching to FlankExampleTest is the easiest way to unblock integration tests.
|
Timestamp: 2023-04-27 18:33:10 |
|
@flank-it |
|
Integration tests succeed for all OSs ✅ |
kaibolay
reviewed
Apr 27, 2023
| - model: iphone8 | ||
| version: 12.0 | ||
| - model: iphone13pro | ||
| version: 15.7 |
There was a problem hiding this comment.
Does this work for this EarlGreyExample?
If not, is this example needed for anything else or should it be deleted entirely?
There was a problem hiding this comment.
EarlGreyExample (as it is now) won't run on iphone13pro/15.7. I think this particular test is not actively used, but this change might be useful in case someone wants to update to EarlGreyExample v2 in the future.
adamvduke
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FTL recently deprecated iphone8/12, so integration tests have been
failing
Fixes #2356