Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "Fixes missing HTTP header X-Goog-User-Project" #2352

Merged

Conversation

adamvduke
Copy link
Contributor

Reverts #2348

Unfortunately, this has unintended consequences for authorization with service accounts. Reverting/releasing a new version to limit the spread of the versions containing this change.

@adamvduke adamvduke changed the title Revert "Fixes missing HTTP header X-Goog-User-Project" fix: Revert "Fixes missing HTTP header X-Goog-User-Project" Mar 10, 2023
@github-actions
Copy link
Contributor

Timestamp: 2023-03-10 19:20:31
Buildscan url for ubuntu-workflow run 4387693761

@adamvduke adamvduke requested a review from schnecle March 10, 2023 19:25
Copy link
Collaborator

@schnecle schnecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamvduke adamvduke merged commit bcbc82a into master Mar 10, 2023
@adamvduke adamvduke deleted the revert-2348-vinaypotluri/missing-X-Goog-User-Project-2347 branch March 10, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants