Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove references to JFrog and Bintray #2306

Merged
merged 1 commit into from
Oct 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/flank-scripts/ops_structure.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@

Flank-scripts `ops` packages mostly match `cli` structure, however, for widely used function there is a separate package
called `common`.
For better code organization `updatebinaries` has a separate package inside `dependencies`, as well as `jfrog` in
`release` package.
For better code organization `updatebinaries` has a separate package inside `dependencies`.
8 changes: 2 additions & 6 deletions docs/flank_secrets.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Flank Secrets

Flank securely communicates to Firebase Test Lab using Google's official Java SDKs for authorization.
Flank securely communicates to Firebase Test Lab using Google's official Java SDKs for authorization.

## 2FA

Expand All @@ -12,8 +12,4 @@ Flank runs require authorization with either a Google user account or a service

## Developing Flank

The Flank release job requires secrets as part of continuous delivery. A [flankbot](https://bintray.com/flankbot) account with [`Member`](https://www.jfrog.com/confluence/display/BT/Bintray+Organizations#:~:text=A%20member%20of%20an%20organization%20in%20Bintray%20can%20create%20repositories,details%2C%20and%20change%20member%20authorizations.) level permission is used to release artifacts on bintray.

- `GITHUB_TOKEN` - Provided by [GitHub Actions](https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token)
- `JFROG_USER` - Username for jfrog authentication
- `JFROG_API_KEY` - API key for jfrog used to publish releases. The API key is found in https://bintray.com/profile/edit
The Flank release job requires secrets as part of continuous delivery. We use our Sonatype account for releasing a new version of Flank to the [Maven Central Repository](https://mvnrepository.com/artifact/com.github.flank/flank).
4 changes: 2 additions & 2 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -978,11 +978,11 @@ v3.0-SNAPSHOT
## Maven

You can consume Flank via maven.
See the [maven repo](https://bintray.com/flank/maven/flank) for all supported versions.
See the [maven repo](https://mvnrepository.com/artifact/com.github.flank/flank) for all supported versions.

```
repositories {
maven(url = "https://dl.bintray.com/flank/maven")
mavenCentral()
}

dependencies {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ object Versions {
// https://github.com/detekt/detekt
const val DETEKT = "0.11.1"

// https://github.com/bintray/gradle-bintray-plugin/releases
const val BINTRAY = "1.8.5"

// https://github.com/johnrengelman/shadow/releases
const val SHADOW = "6.0.0"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ object Versions {
// https://github.com/detekt/detekt
const val DETEKT = "1.13.1"

// https://github.com/bintray/gradle-bintray-plugin/releases
const val BINTRAY = "1.8.5"

// https://github.com/johnrengelman/shadow/releases
const val SHADOW = "6.0.0"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ object Versions {
// https://github.com/detekt/detekt
const val DETEKT = "1.12.0"

// https://github.com/bintray/gradle-bintray-plugin/releases
const val BINTRAY = "1.8.5"

// https://github.com/johnrengelman/shadow/releases
const val SHADOW = "6.0.0"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
object Plugins {

const val PLUGIN_SHADOW_JAR = "com.github.johnrengelman.shadow"
const val DETEKT_PLUGIN = "io.gitlab.arturbosch.detekt"
const val JFROG_BINTRAY = "com.jfrog.bintray"
const val MAVEN_PUBLISH = "maven-publish"
const val BEN_MANES_PLUGIN = "com.github.ben-manes.versions"
object Kotlin {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ object Versions {
// https://github.com/detekt/detekt
const val DETEKT = "1.11.0"

// https://github.com/bintray/gradle-bintray-plugin/releases
const val BINTRAY = "1.8.5"

// https://github.com/johnrengelman/shadow/releases
const val SHADOW = "6.0.0"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ plugins {
jacoco
kotlin(Plugins.Kotlin.PLUGIN_JVM)
id(Plugins.DETEKT_PLUGIN) version Versions.DETEKT
id(Plugins.JFROG_BINTRAY) version Versions.BINTRAY
id(Plugins.MAVEN_PUBLISH)
id(Plugins.PLUGIN_SHADOW_JAR) version Versions.SHADOW
id(Plugins.BEN_MANES_PLUGIN) version Versions.BEN_MANES
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@
"projectUrl": "http://www.github.com/3breadt/dd-plist",
"name": "dd-plist"
},
{
"group": "com.jfrog.bintray",
"version": "1.8.5",
"projectUrl": null,
"name": "com.jfrog.bintray.gradle.plugin"
},
{
"group": "com.linkedin.dextestparser",
"version": "2.2.1",
Expand Down Expand Up @@ -147,7 +141,7 @@
},
"exceeded": {
"dependencies": [

],
"count": 0
},
Expand Down Expand Up @@ -356,7 +350,7 @@
},
"unresolved": {
"dependencies": [

],
"count": 0
},
Expand Down
2 changes: 0 additions & 2 deletions integration_tests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ version = "1.0"

repositories {
mavenCentral()
maven(url = "https://dl.bintray.com/kotlin/ktor")
maven(url = "https://dl.bintray.com/kotlin/kotlinx")
}

dependencies {
Expand Down