Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop loading entire file into memory to fix OOM errors #2274

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

joshafeinberg
Copy link
Contributor

Fixes #2265

Test Plan

How do we know the code works?

The code has been run internally in our company with no issues. We also have all passing tests
.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added the Bug label Aug 12, 2022
@joshafeinberg
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@adamvduke
Copy link
Contributor

adamvduke commented Nov 18, 2022

Hi @joshafeinberg, sorry for the delay in looking at this. Since the creation of your PR, Flank has become a Google managed project, and requires agreeing to the Google CLA.

Additionally, I've been trying your branch out locally, and the integration tests have a few failures. Are you able to run the $ ./gradlew integrationTests task successfully on your end?

@adamvduke
Copy link
Contributor

@VictoriaAuto

@adamvduke
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan:
Linux status failure - Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/3604587723

@joshafeinberg
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan:
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/3604643365

@joshafeinberg joshafeinberg force-pushed the jfein/add-blob-upload branch 2 times, most recently from 420b732 to 9b4d37a Compare December 2, 2022 21:41
@adamvduke adamvduke merged commit 97e52c6 into Flank:master Dec 16, 2022
@ArunYogeshwaran
Copy link

Thanks for this fix - Upgrading Flank version from 21.08.0 to 23.0.10 fixed the issue for us 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.OutOfMemoryError: Java heap space
3 participants