-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop loading entire file into memory to fix OOM errors #2274
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
8c7db73
to
30e9ea7
Compare
Hi @joshafeinberg, sorry for the delay in looking at this. Since the creation of your PR, Flank has become a Google managed project, and requires agreeing to the Google CLA. Additionally, I've been trying your branch out locally, and the integration tests have a few failures. Are you able to run the |
@flank-it |
Integration tests failed ❌ |
@flank-it |
Integration tests succeed for all OSs ✅ |
420b732
to
9b4d37a
Compare
9b4d37a
to
8885092
Compare
Thanks for this fix - Upgrading Flank version from 21.08.0 to 23.0.10 fixed the issue for us 🚀 |
Fixes #2265
Test Plan
The code has been run internally in our company with no issues. We also have all passing tests
.
Checklist