Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Firebase Test Lab matrix details URL for test matrix webLink #2241

Merged
merged 1 commit into from
Apr 5, 2022
Merged

feat: Use Firebase Test Lab matrix details URL for test matrix webLink #2241

merged 1 commit into from
Apr 5, 2022

Conversation

tonybaroneee
Copy link
Contributor

Hey all, Anthony from the Firebase Test Lab team here!

Here's a small PR to update the test matrix webLink to point to the new test matrix details page, which shows all test results listed by test case. We heard from users that they like this new view, as it shows a more holistic picture of all test executions. Let me know what you think. Thanks!

Here's a screenshot of the new page:

image

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tonybaroneee
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@tonybaroneee
Copy link
Contributor Author

recheck

@bootstraponline
Copy link
Contributor

Thank you for the pull request! I sent you an invite to the Flank team and triggered the CI jobs. The code looks great. Once the CI jobs are green, I think this is good to merge.

@tonybaroneee
Copy link
Contributor Author

Much appreciated, thanks for the quick turnaround on this! Looking forward to future collab opportunities!

@bootstraponline bootstraponline merged commit cf7d734 into Flank:master Apr 5, 2022
@bootstraponline
Copy link
Contributor

CI is ✅. Merged!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2022
@tonybaroneee tonybaroneee deleted the update-test-matrix-web-link branch April 6, 2022 00:45
@bootstraponline
Copy link
Contributor

@tonybaroneee
Copy link
Contributor Author

@bootstraponline Great to hear, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants