Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for robo-directives #2207

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

changusmc
Copy link
Contributor

Fixes #2206

Test Plan

How do we know the code works?
Passes all tests and also tested on the production Dropbox app with our robo-directives
.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added the Bug label Jan 28, 2022
@changusmc changusmc changed the title Add support for robo-directives fix: Add support for robo-directives Jan 28, 2022
@changusmc
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bootstraponline
Copy link
Contributor

Thank you for the detailed issue and pull request! The code looks good for me. I am waiting on CI to see if all the tests pass, then I'll merge.

@bootstraponline bootstraponline merged commit 33d6f7a into Flank:master Jan 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
@bootstraponline
Copy link
Contributor

@changusmc The flank snapshot has been updated with this change. Please test and let me know if this works for you. I can then make a stable release.

https://github.com/Flank/flank/releases/tag/flank-snapshot

@changusmc changusmc deleted the robodirective branch January 29, 2022 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roboDirectives are ignored when running in FTL
2 participants