fix: Adds check for .aab format before querying apkDetails

[Xlopec]

Fixes #2188

This PR adds checks for packaging format before querying for APK details. It fixes the following issue #2188

Checklist

• [] Documented
• Unit tested
• [] Integration tests updated

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[bootstraponline]

Thanks for submitting a fix for this issue! I've left some comments.

[bootstraponline]

I think we should only report if it ends with .apk as google may add additional extensions in the future

we should probably also call toLowerCase and trim to avoid whitespace.

[Xlopec]

Ok, what about null case, should we reportPackageName in this case? I guess we will get FileReference.remote == "" in this case

[bootstraponline]

What do you think about this approach?

If the app path doesn't end in .apk, we'll report an empty string. App path can't be null.

diff --git a/test_runner/src/main/kotlin/ftl/client/google/AppDetails.kt b/test_runner/src/main/kotlin/ftl/client/google/AppDetails.kt
index 0a806b70..118b74cd 100644
--- a/test_runner/src/main/kotlin/ftl/client/google/AppDetails.kt
+++ b/test_runner/src/main/kotlin/ftl/client/google/AppDetails.kt
@@ -3,10 +3,14 @@ package ftl.client.google
 import com.google.testing.model.FileReference
 import ftl.http.executeWithRetry

-fun getAndroidAppDetails(gcsAppPath: String): String =
-    GcTesting.get
+fun getAndroidAppDetails(gcsAppPath: String): String {
+    // getApkDetails errors when sent non-apk files such as aab
+    if (gcsAppPath.trim().lowercase().endsWith(".apk").not()) return ""
+
+    return GcTesting.get
         .ApplicationDetailService()
         .getApkDetails(FileReference().apply { gcsPath = gcsAppPath })
         .apply { requestHeaders.set("X-Server-Timeout", 1800) } // 30 min
         .executeWithRetry()
         ?.apkDetail?.apkManifest?.packageName?.toString().orEmpty()
+}

[Xlopec]

Looks good to me, pushed updated code

[bootstraponline]

thank you for adding a test!

[bootstraponline]

@Xlopec it looks like the code is failing lint check. Details in the GitHub actions build jobs.

lintKotlinMain sources failed lint check

$ ./gradlew lintKotlinMain

> Task :test_runner:lintKotlinMain FAILED
/flank/test_runner/src/main/kotlin/ftl/run/platform/RunAndroidTests.kt:16:1: Lint error > [no-wildcard-imports] Wildcard import
/flank/test_runner/src/main/kotlin/ftl/run/platform/RunAndroidTests.kt:17:1: Lint error > [no-unused-imports] Unnecessary import
/flank/test_runner/src/main/kotlin/ftl/run/platform/RunAndroidTests.kt:17:1: Lint error > [no-wildcard-imports] Wildcard import

FAILURE: Build failed with an exception.

[bootstraponline]

@Xlopec If you could sign the CLA, then the builds should turn green.

[Xlopec]

I have read the CLA Document and I hereby sign the CLA

[bootstraponline]

@Xlopec It looks like the test you added is failing in CI.

[bootstraponline]