Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Detect iOS devices as physical #2182

Merged
merged 6 commits into from
Nov 12, 2021
Merged

fix: Detect iOS devices as physical #2182

merged 6 commits into from
Nov 12, 2021

Conversation

bootstraponline
Copy link
Contributor

Fixes #2179

Test Plan

How do we know the code works?

Ran reduced test case via Debug.kt Verified PHYSICAL used as fallback message does not appear. Checked that the cost calculation is correct.

gcloud:
  test: "./test_runner/src/test/kotlin/ftl/fixtures/tmp/ios/EarlGreyExample/EarlGreyExample.zip"
  xctestrun-file: "./test_runner/src/test/kotlin/ftl/fixtures/tmp/ios/EarlGreyExample/EarlGreyExampleSwiftTests.xctestrun"
  device:
  - model: "iphone11pro"
    version: "14.7"
    locale: "en"
    orientation: "portrait"

CostReport
  Physical devices
    $0.08 for 1m

@bootstraponline bootstraponline mentioned this pull request Nov 11, 2021
Closed
@github-actions github-actions bot added the Bug label Nov 11, 2021
@github-actions
Copy link
Contributor

Timestamp: 2021-11-12 04:35:43
Buildscan url for ubuntu-workflow run 1451688249
https://gradle.com/s/bcsnnzqiit5ha

@bootstraponline bootstraponline merged commit 3daebd8 into master Nov 12, 2021
@bootstraponline bootstraponline deleted the ios_detect branch November 12, 2021 04:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iPhone 11 Pro not recognized as correct device
1 participant
@bootstraponline